Datasource: fix a bug where deleting data source will trigger save an… #21300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprokop
requested changes
Jan 2, 2020
There was a problem hiding this comment.
@lzdw thank's for the fix. Looking into the code the problems lies in the fact that both Save & Test and Delete buttons have type submit. Of course your fix is a correct one but it introduces some complexity. My suggestion is to change the code to use Button component from grafana/ui instead of plain buttons. grafana/ui button has default type of button which means that the submit will not happen and the event prevention will not be necessary.
dprokop
requested review from
a team,
torkelo and
peterholmberg
and removed request for
a team and
torkelo
torkelo
reviewed
Jan 2, 2020
public/app/features/datasources/settings/DataSourceSettingsPage.tsx
Outdated
Show resolved
Hide resolved
lzdw
force-pushed
the
delete_data_source
branch
from
0ecb009
to
055b786
Compare
lzdw
force-pushed
the
delete_data_source
branch
from
055b786
to
2fa301d
Compare
torkelo
approved these changes
Jan 7, 2020
ryantxu
added a commit
that referenced
this pull request
Jan 7, 2020
* origin/master: Build: package all binaries for enterprise (#21381) Datasource: fixes prometheus datasource tests - adds align range CircleCI: Testing upgrade to CircleCI 2.1 (#21374) Storybook: Remove reference to jquery.flot.pie file from storybook config (#21378) Cloudwatch: Fixed crash when switching from cloudwatch data source (#21376) Docs: Added Squadcast notifications (#21372) Chore: upgrade d3 (#21368) Datasource: fix a bug where deleting data source will trigger save and test events (#21300) Forms: revamped select (#21092) Toolkit: add git log info to the plugin build report (#21344)
ryantxu
added a commit
that referenced
this pull request
Jan 8, 2020
* grafana/master: TimeZones: fix utc test (#21393) Build: package all binaries for enterprise (#21381) Datasource: fixes prometheus datasource tests - adds align range CircleCI: Testing upgrade to CircleCI 2.1 (#21374) Storybook: Remove reference to jquery.flot.pie file from storybook config (#21378) Cloudwatch: Fixed crash when switching from cloudwatch data source (#21376) Docs: Added Squadcast notifications (#21372) Chore: upgrade d3 (#21368) Datasource: fix a bug where deleting data source will trigger save and test events (#21300) Forms: revamped select (#21092) Toolkit: add git log info to the plugin build report (#21344) Docs: Use https scheme for Grafana playground links (#21360) fix docs links (#21359) AddDatasourcePage: Refactoring & more Phantom plugins (#21261) Chore: Remove empty flot.pie file (#21356) Docs: Fix link (#21358) Docs: Fix InfluxDB templated dashboard link (#21343) Rendering: Fix panel PNG rendering when using sub url & serve_from_sub_path = true (#21306)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d test events
What this PR does / why we need it:
Fix a bug where deleting data source will trigger save and test events
Which issue(s) this PR fixes:
Fixes #21282
Special notes for your reviewer: