Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Use HTTPS scheme for Grafana playground links #21360

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Docs: Use HTTPS scheme for Grafana playground links #21360

merged 1 commit into from
Jan 6, 2020

Conversation

ceh
Copy link
Contributor

@ceh ceh commented Jan 6, 2020

What this PR does / why we need it:

All playground links with a HTTP scheme is redirected to HTTPS. We can link to HTTPS instead, to skip the HTTP->HTTPS redirect flow.

Copy link
Contributor

@oddlittlebird oddlittlebird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improving the docs!

@oddlittlebird oddlittlebird merged commit f0764ce into grafana:master Jan 6, 2020
@ceh ceh deleted the ceh-play-links branch January 6, 2020 18:29
ryantxu added a commit that referenced this pull request Jan 6, 2020
* origin/master: (43 commits)
  Docs: Use https scheme for Grafana playground links (#21360)
  fix docs links (#21359)
  AddDatasourcePage: Refactoring & more Phantom plugins (#21261)
  Chore: Remove empty flot.pie file (#21356)
  Docs: Fix link (#21358)
  Docs: Fix InfluxDB templated dashboard link (#21343)
  Rendering: Fix panel PNG rendering when using sub url & serve_from_sub_path = true (#21306)
  NewsPanel: update default feed url (#21342)
  docs: fix influxdb templated dashboard link (#21336)
  Docs: Update Windows.md (#21333)
  Arrow: don't export arrow... breaking phantomjs e2e test (#21331)
  DataFrame: round trip metadata to arrow Table (#21277)
  Prometheus: user metrics metadata to inform query hints (#21304)
  Panel: disable edit/duplicate/delete entry for repeat panel (#21257)
  Prometheus: Disable suggestions at beginning of value (#21302)
  grafana/ui: Do not build in strict mode as grafana/ui depends on non-strict libs (#21319)
  Docs: Update security.md (#20981)
  @grafana/data: use timeZone parameter rather than isUtc (#21276)
  Units: support dynamic count and currency units (#21279)
  Docs: Added sudo and removed $ where inconsistent. (#21314)
  ...
ryantxu added a commit that referenced this pull request Jan 8, 2020
* grafana/master:
  TimeZones: fix utc test (#21393)
  Build: package all binaries for enterprise (#21381)
  Datasource: fixes prometheus datasource tests - adds align range
  CircleCI: Testing upgrade to CircleCI 2.1 (#21374)
  Storybook: Remove reference to jquery.flot.pie file from storybook config (#21378)
  Cloudwatch: Fixed crash when switching from cloudwatch data source (#21376)
  Docs: Added Squadcast notifications (#21372)
  Chore: upgrade d3 (#21368)
  Datasource: fix a bug where deleting data source will trigger save and test events (#21300)
  Forms: revamped select (#21092)
  Toolkit: add git log info to the plugin build report (#21344)
  Docs: Use https scheme for Grafana playground links (#21360)
  fix docs links (#21359)
  AddDatasourcePage: Refactoring & more Phantom plugins (#21261)
  Chore: Remove empty flot.pie file (#21356)
  Docs: Fix link (#21358)
  Docs: Fix InfluxDB templated dashboard link (#21343)
  Rendering: Fix panel PNG rendering when using sub url & serve_from_sub_path = true (#21306)
@ying-jeanne ying-jeanne added the pr/external This PR is from external contributor label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external This PR is from external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants