Provisioning: Validate that dashboard providers have unique names #22898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergquist
requested changes
Mar 20, 2020
There was a problem hiding this comment.
Looks good!
But I think we need a better way to handle this error when starting grafana. This is the error message I get when I have duplicate dashboard provisioners.
EROR[03-20|22:12:09] Failed to provision dashboard logger=provisioning error="Failed to create provisioner: Failed to read dashboards config: could not parse provisioning config file: dev.yaml error: dashboards name \"gdev dashboards\" is not unique"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x1482ce0]
goroutine 151 [running]:
github.com/grafana/grafana/pkg/services/provisioning.(*provisioningServiceImpl).Run(0xc00053a000, 0x1de04c0, 0xc000056140, 0x0, 0x0)
/home/carl/go/src/github.com/grafana/grafana/pkg/services/provisioning/provisioning.go:89 +0x170
main.(*Server).Run.func1(0x0, 0x0)
/home/carl/go/src/github.com/grafana/grafana/pkg/cmd/grafana-server/server.go:129 +0x60
golang.org/x/sync/errgroup.(*Group).Go.func1(0xc000398450, 0xc000a17200)
/home/carl/go/src/github.com/grafana/grafana/vendor/golang.org/x/sync/errgroup/errgroup.go:57 +0x59
created by golang.org/x/sync/errgroup.(*Group).Go
/home/carl/go/src/github.com/grafana/grafana/vendor/golang.org/x/sync/errgroup/errgroup.go:54 +0x66
Co-Authored-By: Arve Knudsen <arve.knudsen@gmail.com>
|
@bergquist pushed a fix for handling of error when starting grafana which will make Grafana server stop. |
bergquist
changed the title
|
Thank you for contributing to Grafana! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a check if an array of
*DashboardsAsConfighas only unique namesWhich issue(s) this PR fixes:
Fixes #20421
(this is a clean version of #21676 which I've messed up beautifully)
@marefr :)