Migration: New datasource #23221
Migration: New datasource #23221
Conversation
| href={`${learnMoreLink.url}?utm_source=grafana_add_ds`} | ||
| target="_blank" | ||
| rel="noopener" | ||
| onClick={onLearnMoreClick} | ||
| icon={<Icon name="external-link" />} |
There was a problem hiding this comment.
Any thoughts about this usage?
There was a problem hiding this comment.
can't we just set icon to "external-link"
There was a problem hiding this comment.
It originally supported setting it as fa fa-external-link I think. Should maybe remove the fa then, and do some reasonable migration.
There was a problem hiding this comment.
I'll use the fa string for now, and we'll see about that later.
| <input | ||
| ref={ref} | ||
| export const FilterInput = forwardRef<HTMLInputElement, Props>((props, ref) => | ||
| props.useNewForms ? ( |
There was a problem hiding this comment.
Not sure we need this, we can always use new form styles (i think) as this is only used in the top above lists and not together with other input elements
There was a problem hiding this comment.
Good point. I think the pages using it are fairly simple to migrate too, so we should probably be fine.
| href={`${learnMoreLink.url}?utm_source=grafana_add_ds`} | ||
| target="_blank" | ||
| rel="noopener" | ||
| onClick={onLearnMoreClick} | ||
| icon={<Icon name="external-link" />} |
There was a problem hiding this comment.
can't we just set icon to "external-link"
ying-jeanne
added
pr/external
#22862
<Icon/>for theiconprops on Buttons. Any thoughts about this?