Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download CSV: format the dates #24992

Merged
merged 3 commits into from
May 25, 2020
Merged

Download CSV: format the dates #24992

merged 3 commits into from
May 25, 2020

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented May 21, 2020

Fixes #24973

This is a simple fix to replace the field with a formattedvalue. I suspect longer term we will need to have download open a set of options like it did before

@ryantxu ryantxu requested a review from dprokop May 21, 2020 17:06
@ryantxu ryantxu added this to the 7.0.1 milestone May 21, 2020

const formattedDateField = {
...timeField,
type: FieldType.string,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^ not really necessary, but more accurate

@dprokop dprokop merged commit 81d1f66 into master May 25, 2020
@dprokop dprokop deleted the download-with-date branch May 25, 2020 09:12
pull bot pushed a commit to digitalocean/grafana that referenced this pull request May 25, 2020
* export formatted dates

* remove if(true)

* display processor
hugohaggmark pushed a commit that referenced this pull request May 26, 2020
* export formatted dates

* remove if(true)

* display processor

(cherry picked from commit 81d1f66)
hugohaggmark pushed a commit that referenced this pull request May 26, 2020
* export formatted dates

* remove if(true)

* display processor

(cherry picked from commit 81d1f66)
@oholimoli
Copy link

Is there a documentation for this feature? I would like to change the date format in graphs to european.

aknuds1 pushed a commit that referenced this pull request Jun 30, 2020
* export formatted dates

* remove if(true)

* display processor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanelInspect: Downloaded CSV should have human readable time stamps
5 participants