Elasticsearch: Fix date histogram auto interval handling for alert queries #30049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
requested review from
joshhunt and
wbrowne
and removed request for
a team
|
Thanks. This change seemed wrong to me at first sight. I was the one implementing the first version of backend support for elasticsearch. I wonder if something did change in Grafana alerting since last 3 years :) Cannot remember whether this has never worked as expected or not. Could be that Grafana alerting needs an update to solve this problem for "all" data sources I don't know right now. I need to run, but will continue reviewing this tomorrow. |
marefr
requested changes
Jan 13, 2021
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
|
Thank you for contributing to Grafana! |
marefr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The current backend Golang code doesn't honor the minimum interval set in the UI for alerts. This means that the data the alerts are triggering against will never match the data in the visualization. For example, if you're monitoring AWS Cloudwatch EC2 data that only reports every 5 minutes and you set the minimum interval to
5m, the alerts will not trigger correctly because it will use theautointerval instead which for5mof data defaults to200ms.This PR fixes that by setting the minimum interval to the same value in the UI.
Which issue(s) this PR fixes:
Fixes #22082
Special notes for your reviewer: