Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogsPanel: Add deduplication option for logs #31019

Merged
merged 5 commits into from
Feb 10, 2021

Conversation

ivanahuckova
Copy link
Member

What this PR does / why we need it:
In Logs Panel, we are currently supporting the same logs view customisation as in Explore, besides deduplication. This PR adds deduplication support in Logs Panel.

Explore:
image

Logs Panel:
image

image

Which issue(s) this PR fixes:

Fixes #22498

Copy link
Member

@Elfo404 Elfo404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Works like a charm, there are only a couple of unused things (one for which I think the build is not passing)

public/app/plugins/panel/logs/LogsPanel.tsx Outdated Show resolved Hide resolved
public/app/plugins/panel/logs/LogsPanel.tsx Outdated Show resolved Hide resolved
ivanahuckova and others added 2 commits February 9, 2021 12:11
Co-authored-by: Giordano Ricci <gio.ricci@grafana.com>
Co-authored-by: Giordano Ricci <gio.ricci@grafana.com>
@ivanahuckova ivanahuckova merged commit 16c2510 into master Feb 10, 2021
@ivanahuckova ivanahuckova deleted the ivana/dedup-logs-in-panel branch February 10, 2021 13:02
ryantxu pushed a commit that referenced this pull request Feb 24, 2021
* WIP: Add dedup functionality to logs panel

* Simplify, clean up

* Change ordering of customizations based on how it is in Explore

* Update public/app/plugins/panel/logs/LogsPanel.tsx

Co-authored-by: Giordano Ricci <gio.ricci@grafana.com>

* Update public/app/plugins/panel/logs/LogsPanel.tsx

Co-authored-by: Giordano Ricci <gio.ricci@grafana.com>

Co-authored-by: Giordano Ricci <gio.ricci@grafana.com>
@msrpub
Copy link

msrpub commented May 31, 2023

When is this 'feature' expected to be applied to other visuaIization panels? (e.g. Time Series, Stat, Gauge, Bar Gauge, etc)
It would minimize a lot the impacts from unsolved issue:
grafana/loki#7207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loki logs panel deduplication
3 participants