-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LogsPanel: Add deduplication option for logs #31019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Works like a charm, there are only a couple of unused things (one for which I think the build is not passing)
Co-authored-by: Giordano Ricci <gio.ricci@grafana.com>
Co-authored-by: Giordano Ricci <gio.ricci@grafana.com>
* WIP: Add dedup functionality to logs panel * Simplify, clean up * Change ordering of customizations based on how it is in Explore * Update public/app/plugins/panel/logs/LogsPanel.tsx Co-authored-by: Giordano Ricci <gio.ricci@grafana.com> * Update public/app/plugins/panel/logs/LogsPanel.tsx Co-authored-by: Giordano Ricci <gio.ricci@grafana.com> Co-authored-by: Giordano Ricci <gio.ricci@grafana.com>
When is this 'feature' expected to be applied to other visuaIization panels? (e.g. Time Series, Stat, Gauge, Bar Gauge, etc) |
What this PR does / why we need it:
In Logs Panel, we are currently supporting the same logs view customisation as in Explore, besides deduplication. This PR adds deduplication support in Logs Panel.
Explore:
Logs Panel:
Which issue(s) this PR fixes:
Fixes #22498