Loki: Add line limit for annotations #31183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
requested review from
mckn and
natellium
and removed request for
a team
ivanahuckova
commented
Feb 12, 2021
| @@ -124,7 +124,7 @@ export class LokiDatasource extends DataSourceApi<LokiQuery, LokiOptions> { | |||
| runInstantQuery = ( | |||
| target: LokiQuery, | |||
| options: DataQueryRequest<LokiQuery>, | |||
| responseListLength: number | |||
| responseListLength = 1 | |||
There was a problem hiding this comment.
This is in the same way implemented in runRangeQuery.
ryantxu
pushed a commit
that referenced
this pull request
Feb 24, 2021
* Add line limit to Annotation query editor * Refactor to keep type consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We already had line limit and query type fields in Annotation Loki editor since implementing it in dashboard #29356. But unfortunately, these new fields weren't working (you couldn't input the number and couldn't switch query type). This PR fixes it and implements logic to limit number of logs in annotation queries and choose query type.
loki_annotations_limit.mov
Which issue(s) this PR fixes:
Fixes #21308