Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zipkin: Add node graph view to trace response #34414

Merged
merged 6 commits into from
May 20, 2021
Merged

Conversation

aocenas
Copy link
Member

@aocenas aocenas commented May 19, 2021

Similar to #33635 and #31521.

Also contains some refactoring as the code is fairly similar between datasources.

Copy link
Contributor

@davkal davkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor and new zipkin support. Tried this with Zipkin, Tempo, and Jaeger. Node graphs working with all of them.

@aocenas aocenas merged commit 615de9b into main May 20, 2021
@aocenas aocenas deleted the aocenas/zipkin-graph-view branch May 20, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants