QueryVariable: Default to first option when none is set #36521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskarhed
requested review from
mckn,
a team and
thisisobate
and removed request for
a team
tskarhed
changed the title
torkelo
approved these changes
Jul 8, 2021
Comment on lines
126
to
130
| instanceState.current = { ...instanceState.options[0], selected: true }; | ||
| instanceState.options = instanceState.options.map((option, index) => | ||
| index === 0 ? instanceState.current : { ...option, selected: false } | ||
| ); | ||
| return; |
There was a problem hiding this comment.
what happens if options are an empty array? will this crash?
Since this handler can be written mutably and immer will make it immutable. I think you first can just set all options to selected false except first and set instance.current = instance.options[0] ?
There was a problem hiding this comment.
Yeah, we need to add a check to make sure we have options.
tskarhed
commented
Jul 9, 2021
| // If no value is set, default to the first avilable | ||
| if (!current.value && instanceState.options.length) { | ||
| instanceState.options.forEach((option, index) => { | ||
| option.selected = !Boolean(index); |
There was a problem hiding this comment.
Quite enjoyed this fancy little trick 😎
torkelo
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To make sure that query variables do not break when the current dashboard is navigated to via an anchor tag.
Which issue(s) this PR fixes:
Fixes #35471
Special notes for your reviewer:
/d/${__dashboard.uid}