Template variables: Default to first option if URL does not provide

[tskarhed]

Which issue(s) this PR fixes:

Fixes #35471

Special notes for your reviewer:

I'm currently looking at writing tests.

[tskarhed]

Am I missing the reason why the selected option needs to have ""?

 when setOptionFromUrl is dispatched with a custom variable (no refresh property) › and urlValue is undefined then correct actions are dispatched

    expect(received).toEqual(expected) // deep equality

    - Expected  - 2
    + Received  + 2

    @@ -2,12 +2,12 @@
        Object {
          "payload": Object {
            "data": Object {
              "option": Object {
                "selected": false,
    -           "text": "",
    -           "value": "",
    +           "text": "A",
    +           "value": "A",
              },
            },
            "id": "0",
            "type": "custom",
          },

      110 |     }
      111 |
    > 112 |     expect(dispatchedActions).toEqual(actions);
          |                               ^
      113 |     return instance;
      114 |   };
      115 |

      at Object.thenDispatchedActionsShouldEqual (public/test/core/redux/reduxTester.ts:112:31)
      at public/app/features/variables/state/setOptionFromUrl.test.ts:37:18
      at step (node_modules/tslib/tslib.js:143:27)
      at Object.next (node_modules/tslib/tslib.js:124:57)
      at fulfilled (node_modules/tslib/tslib.js:114:62)

[ashharrison90]

code lgtm, but does it solve the problem specified in #35471 (comment)?

seems the problem stated there is that it's defaulting to the first option instead of the option saved in the json. as far as i can tell, this will also default to the first option? it's definitely better than being blank, but idk if it solves the original problem.

[tskarhed]

code lgtm, but does it solve the problem specified in #35471 (comment)?

seems the problem stated there is that it's defaulting to the first option instead of the option saved in the json. as far as i can tell, this will also default to the first option? it's definitely better than being blank, but idk if it solves the original problem.

You're right. I'm not sure how I would approach that though. Defaulting to the first option seems like a better thing than having it blank.

Maybe merge it like this for now and then come back to it?

[ashharrison90]

oh yeah absolutely, it's definitely a step forward 🥳

[hugohaggmark]

I think we need to find a better solution to the root issue here
#35471 (comment)

[hugohaggmark]

Superseeded by #37776