Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fix parse duration for day #36942

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Bug: Fix parse duration for day #36942

merged 1 commit into from
Jul 21, 2021

Conversation

idafurjes
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #36445

Special notes for your reviewer:

@wbrowne
Copy link
Member

wbrowne commented Jul 21, 2021

I think this looks good. Nice work! Ready for review I think 😄

@idafurjes idafurjes added this to the 8.0.7 milestone Jul 21, 2021
@idafurjes idafurjes changed the title Fix parse duration for day Bug: Fix parse duration for day Jul 21, 2021
@idafurjes idafurjes marked this pull request as ready for review July 21, 2021 10:01
@idafurjes idafurjes requested a review from a team as a code owner July 21, 2021 10:01
@idafurjes idafurjes added datasource/MySQL datasource/MSSQL Microsoft SQL Server Data Source datasource/Postgres old backport v8.0.x Mark PR for automatic backport to v8.0.x labels Jul 21, 2021
Copy link
Member

@wbrowne wbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

@grafanabot
Copy link
Contributor

The backport to v8.0.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-36942-to-v8.0.x origin/v8.0.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 1a52dd57cff92967250b7b2f735a21c78f0747fa
# Push it to GitHub
git push --set-upstream origin backport-36942-to-v8.0.x
git switch main
# Remove the local backport branch
git branch -D backport-36942-to-v8.0.x

Then, create a pull request where the base branch is v8.0.x and the compare/head branch is backport-36942-to-v8.0.x.

@idafurjes idafurjes modified the milestones: 8.0.7, 8.1.0 Jul 21, 2021
@idafurjes idafurjes removed the old backport v8.0.x Mark PR for automatic backport to v8.0.x label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query variable with MySQL data source results in error 400
4 participants