Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations: Fix data source template variable that was not available for annotations #37506

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

axelavargas
Copy link
Member

What this PR does / why we need it:

In the migration from Angular to React, we forgot to add the support for Datasource as a template variable in Annotations Settings

Before:

templateVariablesAsDatasourceBefore

After
templateVariablesAsDatasource

Which issue(s) this PR fixes:

Fixes #37087

Special notes for your reviewer:

@axelavargas axelavargas added this to the 8.1.0 milestone Aug 3, 2021
@axelavargas axelavargas self-assigned this Aug 3, 2021
@axelavargas axelavargas requested review from a team, peterholmberg, thisisobate and torkelo and removed request for a team August 3, 2021 16:42
@axelavargas axelavargas merged commit d48e65b into main Aug 3, 2021
@axelavargas axelavargas deleted the axelav/fix-annotations-datasource-as-template branch August 3, 2021 17:54
grafanabot pushed a commit that referenced this pull request Aug 3, 2021
@osg-grafana osg-grafana changed the title Annotations: Fix Datasource as template variable not available for annotations Annotations: Fix data source template variable that was not available for annotations Aug 5, 2021
@osg-grafana
Copy link
Contributor

Please vet the change in title for accuracy, @axelavargas.

@axelavargas
Copy link
Member Author

Please vet the change in title for accuracy, @axelavargas.

It looks correct @osg-grafana , thank you 🙌🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasource as template variable not available for annotations
4 participants