Tracing: Correct tags for each span are shown #41473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We were showing wrong tags in spans. More context here: https://raintank-corp.slack.com/archives/CPXKS6FB5/p1634297506265900
To fix this, we have decided to have 1-1 relationship between span and process. We are using spanID as a key as it should be unique within the trace.
Which issue(s) this PR fixes:
Fixes #40625
Special notes for your reviewer:
I have added test for this. You can also upload this trace to see the difference (after JSON upload fix is merged #41455):