New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus: Upgrades the prometheus http client to 1.13 #47707
Conversation
4fd8288
to
87c5ffe
Compare
Was this change made somewhere else? |
@bboreham - The fix was tested in https://github.com/grafana/grafana-private-mirror/commits/v8.5.0-felmo1. Actual fix will be implemented once the promclient released and tested (in a separate PR). This PR was just here to validate the fix. |
nvm. Will keep this PR open and update this once the promclient released. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
I see it's been added to a 1.13.0 milestone, but no date attached. |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically closed because it has not had activity in the last 2 weeks. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Prometheus client library has now been released with the fix. |
Signed-off-by: bergquist <carl.bergquist@gmail.com>
Creating a new PR was faster than resolving merge conflicts :) #53901 |
PR to validate the fix prometheus/client_golang#1022