-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traces: APM table #48654
Traces: APM table #48654
Conversation
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/18205 |
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/18438 |
docs/sources/datasources/tempo.md
Outdated
|
||
To display the APM table: | ||
|
||
1. Enable the tempoApmTable feature flag in your ini file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Activate?
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/21415 |
Looking at this again, the values always seem to match now. Not sure if you fixed the query or my data was just weird.
I'm not sure if there is any precedent in other areas in Grafana? A rate is usually expressed as x per seconds, so it might not be necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀
I have some unfortunate news though: we discovered that the metrics emitted by Tempo have a slightly different name from those from the agent and the OTel Collector. Our original intention was to align metric names and labels so it would be easy to use both, but somehow I still managed to use different names in Tempo 🙃 We will be correcting this in Tempo (breaking change): grafana/tempo#1478
And the I think the current PR uses the old metric names, we should switch this by the time this feature is released (does not have to be part of this PR). |
The APM table adds application performance management functionality above the traces view service graph, and is based on discussions/improvements with the Tempo team.
This PR also includes a fix to allow the service graph (and so also the APM table) to be viewed in a dashboard.
Special notes for your reviewer: