Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traces: APM table #48654

Merged
merged 65 commits into from
Jun 9, 2022
Merged

Traces: APM table #48654

merged 65 commits into from
Jun 9, 2022

Conversation

joey-grafana
Copy link
Contributor

@joey-grafana joey-grafana commented May 3, 2022

The APM table adds application performance management functionality above the traces view service graph, and is based on discussions/improvements with the Tempo team.

This PR also includes a fix to allow the service graph (and so also the APM table) to be viewed in a dashboard.

Screenshot 2022-05-28 at 10 31 32

Special notes for your reviewer:

  1. You can use this Gist to setup your dev env to run the table
  2. Enable tempoServiceGraph & tempoApmTable in your custom.ini

@joey-grafana joey-grafana added this to the 9.0.0 milestone May 7, 2022
@joey-grafana joey-grafana added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 7, 2022
@grafanabot
Copy link
Contributor

@grafanabot
Copy link
Contributor


To display the APM table:

1. Enable the tempoApmTable feature flag in your ini file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activate?

docs/sources/datasources/tempo.md Outdated Show resolved Hide resolved
docs/sources/datasources/tempo.md Outdated Show resolved Hide resolved
@grafanabot
Copy link
Contributor

@kvrhdn
Copy link
Member

kvrhdn commented Jun 9, 2022

I'm not able to recreate the value shown in the rate column, the shown value seems to be almost double what I would expect (see screenshot). Besides using $__range and @ end(), is the query used by the table different?
Weirdly enough, I don't have this issue with the error rate column. Values align with my direct promql query.

Looking at this again, the values always seem to match now. Not sure if you fixed the query or my data was just weird.

with the above in mind, would you still like me to update the rate col name? Also, should I update the error rate col name too?

I'm not sure if there is any precedent in other areas in Grafana? A rate is usually expressed as x per seconds, so it might not be necessary.

Copy link
Member

@kvrhdn kvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@kvrhdn
Copy link
Member

kvrhdn commented Jun 9, 2022

I have some unfortunate news though: we discovered that the metrics emitted by Tempo have a slightly different name from those from the agent and the OTel Collector. Our original intention was to align metric names and labels so it would be easy to use both, but somehow I still managed to use different names in Tempo 🙃

We will be correcting this in Tempo (breaking change): grafana/tempo#1478
The following metrics will change:

  • traces_spanmetrics_duration_seconds_bucket -> traces_spanmetrics_latency_bucket
  • traces_spanmetrics_duration_seconds_count -> traces_spanmetrics_latency_count
  • traces_spanmetrics_duration_seconds_sum -> traces_spanmetrics_latency_sum

And the span_status label will become status_code.

I think the current PR uses the old metric names, we should switch this by the time this feature is released (does not have to be part of this PR).

@joey-grafana joey-grafana modified the milestones: 9.0.1, 9.1.0 Jun 9, 2022
@joey-grafana joey-grafana added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Jun 9, 2022
@joey-grafana joey-grafana changed the title APM table Traces: APM table Jun 9, 2022
@joey-grafana joey-grafana merged commit 4ed7ff2 into main Jun 9, 2022
@joey-grafana joey-grafana deleted the joey/apm_table branch June 9, 2022 16:56
@eleijonmarck eleijonmarck modified the milestone: 9.1.0-beta1 Aug 2, 2022
@IevaVasiljeva IevaVasiljeva modified the milestone: 9.1.0-beta1 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/backend area/explore area/frontend datasource/Prometheus datasource/Tempo enterprise-ok no-backport Skip backport of PR type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APM table
8 participants