Add role_attribute_path and role_attribute_path_strict to auth.gitlab #49147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update defaults.ini to add role_attribute_path
|
|
zoltanbedi
requested review from
a team,
gamab and
Jguer
and removed request for
a team
|
Hello, |
|
Hello @papagian , |
gamab
approved these changes
Jun 2, 2022
Jguer
approved these changes
Jun 2, 2022
|
Tested using docker as in the original issue. Can confirm it also works |
grafanabot
pushed a commit
that referenced
this pull request
Jun 3, 2022
gamab
pushed a commit
that referenced
this pull request
Jun 3, 2022
cf. https://community.grafana.com/t/grafana-gitlab-oauth-env-variable-not-recognized/65039 and #48637 (cherry picked from commit 31a4d97) Co-authored-by: Copolycube <kaourintin+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
adds 2 parameters from auth.generic to auth.gitlab module since they are not recognized when added as environment variables.
Which issue(s) this PR fixes:
The intention is to fix #48637
Fixes #48637
Special notes for your reviewer:
hoping that it's as simple as this, as suggested by https://community.grafana.com/t/grafana-gitlab-oauth-env-variable-not-recognized/65039/2 but I must acknowledge that I didn't go through the whole grafana code.