gitlab oauth: account for role_attribute_path_strict #50088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jguer
approved these changes
Jun 2, 2022
gamab
requested review from
sakjur,
kylebrandt and
ying-jeanne
and removed request for
a team
gamab
changed the title
auth.gitlab: account for role_attribute_path_strict
gamab
added
no-changelog
gamab
changed the title
gamab
added
no-changelog
grafanabot
pushed a commit
that referenced
this pull request
Jun 3, 2022
(cherry picked from commit 6c7b6a7)
gamab
added a commit
that referenced
this pull request
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With #49147 we added support for an ENV override of
GF_AUTH_GITLAB_ROLE_ATTRIBUTE_PATH_STRICT.This PR is aligning the backend to support this parameter:
gitlab_oauthwill handlerole_attribute_path_strictthe same waygeneric_oauthandokta_oauthare.Which issue(s) this PR fixes:
Fixes https://github.com/grafana/grafana-enterprise/issues/3407
Special notes for your reviewer: