ValueFormats: Prevent rounding down of values for "Number" format #49926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaydelaney
requested review from
a team,
JoaoSilvaGrafana,
leventebalogh,
scottlepp and
mdvictor
and removed request for
a team
joshhunt
approved these changes
May 31, 2022
kaydelaney
added
the
no-changelog
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/20418 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/20441 |
|
It does not make for a good default experience showing this many decimals in legend, tooltip, stats etc
|
|
Closing this for now |
|
@kaydelaney @joshhunt how about we add a new number unit that does show all decimals by default? Not sure what to call it though |
This was referenced Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Prevents auto decimal handling for the "Number" format, so precision isn't lost.
Which issue(s) this PR fixes:
Closes #49388