PanelEdit: Add Decimal value formatter to disable and decimal rounding #53577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
added
type/feature-request
area/units
add to changelog
area/panel/edit
no-backport
torkelo
reviewed
Aug 11, 2022
| @@ -39,6 +39,7 @@ export const getCategories = (): ValueFormatCategory[] => [ | |||
| name: 'Misc', | |||
| formats: [ | |||
| { name: 'Number', id: 'none', fn: toFixedUnit('') }, | |||
| { name: 'Decimal', id: 'decimal', fn: stringFormater }, | |||
There was a problem hiding this comment.
Suggested change
| { name: 'Decimal', id: 'decimal', fn: stringFormater }, | |
| { name: 'Number (Full precision)', id: 'decimal', fn: stringFormater }, |
The name Decimals seems to not really capture it I feel.
Alt names
- Number (Raw)
- Number (Full precision)
- Raw (no formatting)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new unit value formatter "Decimal" (that is just the the String value formatter) to create a (hopefully) more obvious way to disable decimal values from being rounded.
We don't want to change the default behaviour of the number formatter because we optimise for most queries people make - Prometheus producing values with many decimal points.
Which issue(s) this PR fixes:
Fixes #49388
Special notes for your reviewer:
I'm not sure if just aliasing the string formatter is the best approach, but it's essentially what @kaydelaney did in her earlier PR. thoughts @torkelo @kaydelaney ?