Plugins: Support headers field for check health #49930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marefr
requested review from
wbrowne,
sakjur,
papagian,
kylebrandt,
achatterjee-grafana,
GrafanaWriter and
jackw
and removed request for
a team
grafanabot
added
type/docs
wbrowne
reviewed
May 31, 2022
| @@ -67,6 +67,18 @@ type DataSource struct { | |||
| Updated time.Time `json:"updated"` | |||
| } | |||
|
|
|||
| // AllowedCookies parses the jsondata.keepCookies and returns a list of | |||
| // allowed cookies, otherwise an empty list. | |||
| func (ds DataSource) AllowedCookies() []string { | |||
wbrowne
approved these changes
May 31, 2022
grafanabot
pushed a commit
that referenced
this pull request
May 31, 2022
(cherry picked from commit a781327)
marefr
added a commit
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrades grafana-plugin-sdk-go to v0.135.0 and implements support for new
Headersfield onCheckHealthRequest.Which issue(s) this PR fixes:
Ref grafana/grafana-plugin-sdk-go#496
Special notes for your reviewer: