Angular: Adds back two angular directives that are still used by remaining angular bits and plugins #50380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ining angular bits and plugins
torkelo
requested review from
a team,
zoltanbedi and
mdvictor
and removed request for
a team
torkelo
requested review from
jackw
and removed request for
zoltanbedi and
mdvictor
torkelo
commented
Jun 8, 2022
| <h3 class="page-heading">MS SQL connection</h3> | ||
|
|
||
| <div class="gf-form-group"> | ||
| <div class="gf-form max-width-30"> | ||
| <span class="gf-form-label width-7">Host</span> | ||
| <input type="text" class="gf-form-input" style="width: 352px" ng-model='ctrl.current.url' placeholder="localhost" bs-typeahead="{{['localhost', 'localhost" required></input> |
There was a problem hiding this comment.
this line is the only one that changed, the bs-typeahead line was an incomplete expression. Then prettier formatted the whole document :)
| return value; | ||
| }, | ||
| }); | ||
| var typeahead = element.dat('typeahead'); |
There was a problem hiding this comment.
Should be
var tooltip = element.data('tooltip');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds back bs-tooltip and bs-typeahead that where removed when I removed the angular-strap file