GrafanaData: Fix week start for non-English browsers #50582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
requested review from
a team,
kaydelaney,
JoaoSilvaGrafana,
leventebalogh,
codeincarnate and
oscarkilhed
and removed request for
a team
spinillos
approved these changes
Jun 10, 2022
AgnesToulet
changed the title
leventebalogh
approved these changes
Jun 14, 2022
It's not used in Grafana codebase but as it's part of |
|
You are absolutely right @AgnesToulet, sorry, I somehow missed that. 👍 |
AgnesToulet
changed the title
grafanabot
pushed a commit
that referenced
this pull request
Jun 14, 2022
* grafana-data: Fix start week for non-English browsers * apply review suggestion (cherry picked from commit 99c8ce5)
AgnesToulet
added a commit
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the week start behavior on browsers using another language than English. The issue was that
weekdays()return the week days in the set locale and we compare it with values from the backend that are always in English (at least for now); so we couldn't find the week day index and setting the week start in the preferences or the dashboard settings didn't work.Special notes for your reviewer:
I didn't find a better way to ensure that the
getWeekdayIndexfunction doesn't change the locale but I'm not very familiar withmoment. I couldn't find anything else in the doc though.