-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update backend architecture contributor documentation #51172
Conversation
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/24379 |
// the service except for in Wire. | ||
type Svc struct { … } | ||
|
||
func ProviceSvc(numbers numerical.Numerical, db db.DB) Svc { … } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it worths briefly explaining wire use and linking to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave that out for this PR, but good point for future improvement, thanks!
Get(ctx.Context, id int) (root.Letter, error) | ||
Delete(ctx.Context, root.DeleteLetterCommand) error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not important but for completeness we need also a function for listing that returns (root.Letters, error)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, getting away with not having that is why there's a "Cached" in the name of the List function 🙃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering about that "Cached"... 😄
Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/24706 |
Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/24740 |
What this PR does / why we need it:
We haven't done this in a while 🙈