Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Add method to provisioning API for obtaining a group and its rules #51761

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Alerting: Add method to provisioning API for obtaining a group and its rules #51761

merged 1 commit into from
Jul 5, 2022

Conversation

alexweav
Copy link
Contributor

@alexweav alexweav commented Jul 5, 2022

Manual backport of #51398

@alexweav
Alerting: Add method to provisioning API for obtaining a group and it…
76fadd1 
…s rules (#51398)

* Generate shell for new route

* Propagate path parameters

* Implement route logic

* Add a couple simple tests

* Use NotFound error for not found, avoid returning pointer

* Regenerate

(cherry picked from commit b9c7eb1)
@alexweav alexweav added this to the 9.0.3 milestone Jul 5, 2022
@alexweav alexweav requested review from a team, gotjosh and joeblubaugh and removed request for a team July 5, 2022 17:08
JohnnyQQQQ
JohnnyQQQQ approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@JohnnyQQQQ JohnnyQQQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexweav alexweav merged commit 96c7f6e into v9.0.x Jul 5, 2022
@alexweav alexweav deleted the backport-51398-to-v9.0.x branch July 5, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnnyQQQQ JohnnyQQQQ JohnnyQQQQ approved these changes

@gotjosh gotjosh Awaiting requested review from gotjosh

@joeblubaugh joeblubaugh Awaiting requested review from joeblubaugh

Assignees
No one assigned
Labels
add to changelog area/alerting Grafana Alerting area/backend backport A backport PR enterprise-ok
Projects
Alerting
Archived in project
Milestone
9.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@alexweav @JohnnyQQQQ