Loki: Improve handling of empty responses #52397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor
requested review from
svennergr,
ivanahuckova and
a team
and removed request for
a team
gabor
changed the title
svennergr
approved these changes
Jul 18, 2022
| // it's hard to say if this is an error-case or not. | ||
| // we know the http-response was a success-response | ||
| // (otherwise we wouldn't be here in the code), | ||
| // so we will go with a success, with no data. |
There was a problem hiding this comment.
I like the comment. However, since this seems like a rare occasion, should we add some logging here? But I am also fine without it.
There was a problem hiding this comment.
hmm.. i'd say let's go without logging for now. i'm planning to add some way to record this strange response in a separate PR.
toddtreece
reviewed
Jul 18, 2022
grafanabot
pushed a commit
that referenced
this pull request
Jul 19, 2022
(cherry picked from commit 46eec85)
gabor
added a commit
that referenced
this pull request
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helps with #52046
the loki http response parser calls
converter.ReadPrometheusStyleResult(https://github.com/grafana/grafana/blob/main/pkg/util/converter/prom.go#L27), which can return a nil-pointer. the loki code did not handle this case.the linked github-issue describes such a situation.
this pull-request adds code to handle the nil-pointer case.
how to test:
(NOTE: this will not resolve the reported issue (why are we not getting back any data for the log-volume-query), but we should handle the nil-pointer-case.