Prometheus: Promote Azure auth flag to configuration #53447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
requested review from
polibb,
ashharrison90,
jackw,
scottlepp,
mdvictor,
papagian,
kylebrandt and
sh0rez
and removed request for
a team
andresmgot
added
add to changelog
backport v9.1.x
7 tasks
grafanabot
pushed a commit
that referenced
this pull request
Aug 11, 2022
(cherry picked from commit a31d96d)
andresmgot
added a commit
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Refresh of #49970
Azure authentication has been in Prometheus as an experimental feature for quite some time and is ready to have experimental flag removed.
As discussed offline, this setting will be still managed through configuration.
Which issue(s) this PR fixes:
Fixes #35857
Special notes for your reviewer:
Please @kostrse take a look!
I believe @grafana/observability-metrics should give the final 👍 Thanks!