Histogram: Fix panel hide when clicking on legend #53651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdvictor
requested review from
a team,
codeincarnate,
davkal,
zoltanbedi and
oscarkilhed
and removed request for
a team
zoltanbedi
reviewed
Aug 12, 2022
| @@ -199,7 +199,7 @@ const prepConfig = (frame: DataFrame, theme: GrafanaTheme2) => { | |||
| colorMode, | |||
| pathBuilder, | |||
| //pointsBuilder: config.drawPoints, | |||
| show: !customConfig.hideFrom?.vis, | |||
There was a problem hiding this comment.
No way! Where is typescript when you need it the most?
zoltanbedi
approved these changes
Aug 12, 2022
mdvictor
added
area/panel/histogram
no-changelog
You're right. I'll look into it and try to do it in this PR |
|
This pull request was removed from the 9.1.0 milestone because 9.1.0 is currently being released. |
grafanabot
pushed a commit
that referenced
this pull request
Aug 17, 2022
(cherry picked from commit 2d391c9)
grafanabot
pushed a commit
that referenced
this pull request
Aug 17, 2022
(cherry picked from commit 2d391c9)
mdvictor
added a commit
that referenced
this pull request
Aug 17, 2022
mdvictor
added a commit
that referenced
this pull request
Aug 17, 2022
daniellee
added
add to changelog
and removed
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Small fix that allow histogram panel to hide/show series when series clicked from legend.
Which issue(s) this PR fixes:
Fixes #52671