Alerting: Fix order-of-magnitude bug in DTO conversion when reading rules #53690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
added
type/bug
area/alerting
yuri-tceretian
approved these changes
Aug 12, 2022
alexweav
added
no-changelog
grafanabot
pushed a commit
that referenced
this pull request
Aug 12, 2022
(cherry picked from commit ccd41df)
alexweav
added a commit
that referenced
this pull request
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the same vein as: #53196
GETting a rule would always return the wrong value forforbecause of this order-of-magnitude bug in the conversion method.time.Durationandmodel.Durationuse the same order of magnitude in the underlying representation, and don't need to be adjusted. The adjustment caused the value to be wrong (typically the value was lowered so much it got truncated to 0s)Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
Didn't add a test for this as our entire DTO package needs better infra. Filed a debt issue instead #53689