PublicDashboards: Dont support exemplars #54933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey were exclusively made for it. When grouping dashboard queries, remove the exemplar property if it exists. We wont be supporting exemplars for pubdash right now since all the exemplar transformation happens within the prometheus datasource on the frontend.
owensmallwood
added
no-backport
owensmallwood
requested review from
jalevin,
guicaulada,
juanicabanas and
evictorero
owensmallwood
requested review from
sakjur,
sh0rez,
ying-jeanne,
jdbaldry and
alyssawada
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/32767 |
|
This pull request was removed from the 9.1.4 milestone because 9.1.4 is currently being released. |
evictorero
reviewed
Sep 12, 2022
|
nit related to the title: The area should be one word in camel case and the description should start with capital letter. |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/33301 |
owensmallwood
added
add to changelog
and removed
no-changelog
owensmallwood
changed the title
owensmallwood
changed the title
owensmallwood
deleted the
owensmallwood/pubdash-dont-support-exemplars
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Exemplars are handled within the Prometheus datasource on the frontend. There's a lot of code that handles those transformations, and currently, it's low priority to add exemplar support for our
PublicDashboardDatasource.Solution
When gathering queries on the backend for public dashboards, we remove the exemplar property if it exists.
Notes
I moved the dashboard_queries into the publicdashboards service because they're only used for public dashboards.
fixes #54035