Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudWatch: Add AWS/States metrics #55427

Merged
merged 1 commit into from
Sep 22, 2022
Merged

CloudWatch: Add AWS/States metrics #55427

merged 1 commit into from
Sep 22, 2022

Conversation

jangaraj
Copy link
Contributor

@jangaraj jangaraj commented Sep 19, 2022 •
edited
Loading

StateTransition is a ServiceMetric dimension value, not a dimension:
image

Ref: https://docs.aws.amazon.com/step-functions/latest/dg/procedure-cw-metrics.html

@jangaraj jangaraj requested a review from a team as a code owner September 19, 2022 22:45
@jangaraj jangaraj requested review from iwysiu and sarahzinger and removed request for a team September 19, 2022 22:45
@grafanabot grafanabot added area/backend datasource/CloudWatch pr/external This PR is from external contributor labels Sep 19, 2022
iwysiu
iwysiu approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@sunker sunker added this to the 9.2.0 milestone Sep 22, 2022
@sunker sunker added the no-backport Skip backport of PR label Sep 22, 2022
@sunker sunker changed the title CloudWatch: updated AWS/States metrics CloudWatch: Add AWS/States metrics Sep 22, 2022
sunker
sunker approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sunker sunker merged commit e5619c0 into grafana:main Sep 22, 2022
@dsotirakis dsotirakis modified the milestones: 9.2.0, 9.2.0-beta1 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunker sunker sunker approved these changes

@iwysiu iwysiu iwysiu approved these changes

@sarahzinger sarahzinger Awaiting requested review from sarahzinger sarahzinger is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
add to changelog area/backend datasource/CloudWatch no-backport Skip backport of PR pr/external This PR is from external contributor
Projects
None yet
Milestone
9.2.0-beta1
Development

Successfully merging this pull request may close these issues.
5 participants
@jangaraj @sunker @iwysiu @dsotirakis @grafanabot