PublicDashboard: Add RTK Query with loading and error state. Add MSW dependency for testing. #55518
Conversation
juanicabanas
requested review from
dprokop and
JoaoSilvaGrafana
and removed request for
a team
juanicabanas
changed the title
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/34308 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/34426 |
...c/app/features/dashboard/components/ShareModal/SharePublicDashboard/PubDashConfiguration.tsx
Outdated
Show resolved
Hide resolved
...c/app/features/dashboard/components/ShareModal/SharePublicDashboard/SharePublicDashboard.tsx
Outdated
Show resolved
Hide resolved
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/34462 |
evictorero
changed the title
juanicabanas
changed the title
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/34495 |
| publicDashboardEnabled: data.isEnabled, | ||
| }); | ||
| }, | ||
| invalidatesTags: ['Config'], |
There was a problem hiding this comment.
So this means calling the saveConfig endpoint invalidates the cached results for the getConfig endpoint?
There was a problem hiding this comment.
exactly, because getConfig has 'Config' tag
| <Checkbox | ||
| label="Your entire dashboard will be public" | ||
| value={acknowledgements.public} | ||
| data-testid={selectors.WillBePublicCheckbox} |
There was a problem hiding this comment.
Nice 👍 I like how were keeping all our selectors separate
| let mockDashboard: DashboardModel; | ||
| let mockPanel: PanelModel; | ||
|
|
||
| beforeAll(() => { |
There was a problem hiding this comment.
Was everything in here needed to be able to render ShareModal?
| import { ShareModal } from '../ShareModal'; | ||
|
|
||
| const server = setupServer( | ||
| rest.get('/api/dashboards/uid/:uId/public-config', (req, res, ctx) => { |
There was a problem hiding this comment.
Is this mocked api specifically for RTK? Or would it still work if we're not using RTK?
There was a problem hiding this comment.
it would still work without using RTK Query. MSW is a library which intercepts the request in the network layer, so it's agnostic about how you make that request.
However, it's recommended to use this library for RTK Query and I couldn't find another way of mocking the requests
| }), | ||
| }); | ||
|
|
||
| export const { useGetConfigQuery, useSaveConfigMutation } = publicDashboardApi; |
There was a problem hiding this comment.
Could we simplify the names to useGetConfig and useSaveConfig?
There was a problem hiding this comment.
Unfortunately, this is something that is added automatically by RTK Query.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes: https://github.com/grafana/grafana-enterprise/issues/4457
Special notes for your reviewer:
Fetch Loading state:
Save Loading state:
