Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PublicDashboards: Add annotations support #56413

Merged
merged 49 commits into from
Oct 19, 2022
Merged

PublicDashboards: Add annotations support #56413

merged 49 commits into from
Oct 19, 2022

Commits on Oct 4, 2022

  1. Adds backend pubdash support for annotations

    @owensmallwood
    owensmallwood committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a526987 View commit details
    Browse the repository at this point in the history

  2. Adds frontend support for pubdash annotations

    @owensmallwood
    owensmallwood committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    8889988 View commit details
    Browse the repository at this point in the history

  3. dont get rules when its a public dashboard

    @owensmallwood
    owensmallwood committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    baf4e58 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into owensmallwood/pubdash-add-annotations-support

    @owensmallwood
    owensmallwood committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    ded15f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Only send out request for grafana annotations. Don't support query an… 

    …notations yet.
    @owensmallwood
    owensmallwood committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    1db5187 View commit details
    Browse the repository at this point in the history

  2. Adds permissions for getting annotations. Anonymous user needs to be … 

    …able to read the dashboard and dashboard annotations.
    @owensmallwood
    owensmallwood committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e420e4e View commit details
    Browse the repository at this point in the history

  3. regenerates mocks for pubdash service

    @owensmallwood
    owensmallwood committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    5091e31 View commit details
    Browse the repository at this point in the history

  4. Adds validation for getting pubdash annotations

    @owensmallwood
    owensmallwood committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    fcb47a1 View commit details
    Browse the repository at this point in the history

  5. Fixes failing tests. Needed to provide annotations service.

    @owensmallwood
    owensmallwood committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    9ee81c1 View commit details
    Browse the repository at this point in the history

  6. Adds tests for pubdash annotations api

    @owensmallwood
    owensmallwood committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    e23cf1d View commit details
    Browse the repository at this point in the history

  7. formatting

    @owensmallwood
    owensmallwood committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    5f75198 View commit details
    Browse the repository at this point in the history

  8. Generates mock for annotations service

    @owensmallwood
    owensmallwood committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    a2eb4ba View commit details
    Browse the repository at this point in the history

  9. Adds pubdash service tests for getting annotations

    @owensmallwood
    owensmallwood committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    1747f98 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. change annotations repo on http_server back to private

    @owensmallwood
    owensmallwood committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    302535f View commit details
    Browse the repository at this point in the history

  2. JsonEditorSettings: Fix invisible json editor

    @kaydelaney
    kaydelaney committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0651445 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into owensmallwood/pubdash-add-annotations-support

    @owensmallwood
    owensmallwood committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    0b773a0 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/fix-json-editor-settings' into o… 

    …wensmallwood/pubdash-add-annotations-support
    @owensmallwood
    owensmallwood committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    9639d9a View commit details
    Browse the repository at this point in the history

  5. Gets pubdash annotations from the backend in one request. WIP

    @owensmallwood
    owensmallwood committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    8bb014f View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Gathers all pubdash annotations on the backend. Uses default annotati… 

    …ons support to process them. Still WIP. Some issues with colours.
    @owensmallwood
    owensmallwood committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    0afb9f4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into owensmallwood/pubdash-add-annotations-support

    @owensmallwood
    owensmallwood committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    234287e View commit details
    Browse the repository at this point in the history

  3. Updates pubdash annotations tests

    @owensmallwood
    owensmallwood committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    6b8a9c8 View commit details
    Browse the repository at this point in the history

  4. Excludes annotation queries when looping over dashboard annotations. … 

    …Updates tests. Adds some test helpers.
    @owensmallwood
    owensmallwood committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    c28a48e View commit details
    Browse the repository at this point in the history

  5. Updates test to make sure disabled dashboard annotations are excluded.

    @owensmallwood
    owensmallwood committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    a3ff68b View commit details
    Browse the repository at this point in the history

  6. removes stuff from bad merge

    @owensmallwood
    owensmallwood committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    c200233 View commit details
    Browse the repository at this point in the history

  7. removes more from bad merge

    @owensmallwood
    owensmallwood committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    430f6df View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Uses generated type for dashboard annotations. Adds cue schema for an… 

    …notation target. Regenerated dashboard cue file. Updates pubdash annotations tests.
    @owensmallwood
    owensmallwood committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    0e5b6f9 View commit details
    Browse the repository at this point in the history

  2. regenerates pubdash service mock

    @owensmallwood
    owensmallwood committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    64b3406 View commit details
    Browse the repository at this point in the history

  3. renames test helper function

    @owensmallwood
    owensmallwood committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    d79798d View commit details
    Browse the repository at this point in the history

  4. removes unused struct

    @owensmallwood
    owensmallwood committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    50a1e46 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. adds comment

    @owensmallwood
    owensmallwood committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    4000e10 View commit details
    Browse the repository at this point in the history

  2. Adds tests to pubdash frontend ds

    @owensmallwood
    owensmallwood committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    23974b1 View commit details
    Browse the repository at this point in the history

  3. adds support for tag annotation queries

    @owensmallwood
    owensmallwood committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    9cfdcbc View commit details
    Browse the repository at this point in the history

  4. makes sure duplicate events are not returned. Events from tag queries… 

    … will take priority and overwrite existing events.
    @owensmallwood
    owensmallwood committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    c25e6d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. fixes failing frontend and backend tests for pubdash

    @owensmallwood
    owensmallwood committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    cec0371 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into owensmallwood/pubdash-add-annotations-support

    @owensmallwood
    owensmallwood committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    ee705c8 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Makes a new schema for Annotation Target. Accidentally used the Panel… 

    … Target before. Regenerates cue files.
    @owensmallwood
    owensmallwood committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    feaa835 View commit details
    Browse the repository at this point in the history

  2. some small refactors and cleanup

    @owensmallwood
    owensmallwood committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    71feb57 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into owensmallwood/pubdash-add-annotations-support

    @owensmallwood
    owensmallwood committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    346191e View commit details
    Browse the repository at this point in the history

  4. renames repo

    @owensmallwood
    owensmallwood committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    e41cfc3 View commit details
    Browse the repository at this point in the history

  5. adds helpful comment

    @owensmallwood
    owensmallwood committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    53c1cea View commit details
    Browse the repository at this point in the history

  6. refactors scopes to use constants

    @owensmallwood
    owensmallwood committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    c59e3da View commit details
    Browse the repository at this point in the history

  7. had to move internal package test helper to its own file in models pa… 

    …ckage due to import cycles in tests
    @owensmallwood
    owensmallwood committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ec55cd3 View commit details
    Browse the repository at this point in the history

  8. formats imports. Removes helper function because linter says its a se… 

    …curity issue
    @owensmallwood
    owensmallwood committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    8dccc5d View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into owensmallwood/pubdash-add-annotations-support

    @owensmallwood
    owensmallwood committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    acaf30f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. If it's a tags annotation, don't scope query by dashboard id since ta… 

    …gs queries span across all dashboards in the org. Updates test for anon user permissions.
    @owensmallwood
    owensmallwood committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    45550c1 View commit details
    Browse the repository at this point in the history

  2. linter fix - ineffectual assignment to error

    @owensmallwood
    owensmallwood committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    4e0437d View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. resolves PR comments. Moves some test helper functions into the tests… 

    … themselves. Adds another test around generating permissions for annotations.
    @owensmallwood
    owensmallwood committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    27e5d6c View commit details
    Browse the repository at this point in the history

  2. Merged master. Resolved conflicts.

    @owensmallwood
    owensmallwood committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    3f02f95 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into owensmallwood/pubdash-add-annotations-support

    @owensmallwood
    owensmallwood committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    884ca8f View commit details
    Browse the repository at this point in the history