Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PublicDashboards: Add annotations support #56413
PublicDashboards: Add annotations support #56413
Changes from all commits
a526987
8889988
baf4e58
ded15f6
1db5187
e420e4e
5091e31
fcb47a1
9ee81c1
e23cf1d
5f75198
a2eb4ba
1747f98
302535f
0651445
0b773a0
9639d9a
8bb014f
0afb9f4
234287e
6b8a9c8
c28a48e
a3ff68b
c200233
430f6df
0e5b6f9
64b3406
d79798d
50a1e46
4000e10
23974b1
9cfdcbc
c25e6d0
cec0371
ee705c8
feaa835
71feb57
346191e
e41cfc3
53c1cea
c59e3da
ec55cd3
8dccc5d
acaf30f
45550c1
4e0437d
27e5d6c
3f02f95
884ca8f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not totally necessary. I'm using the generated dashboard types, but I still want to be explicit about what models/types we want to be used within pubdash. I think its helpful to the next reader to keep all the models we want to use in one place. It def would have helped me. I had no idea the generated types existed before this, and ended up creating my own AnnotationQuery type.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.