Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeRangeInput: Fix clear button type #56545

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

Clarity-89
Copy link
Contributor

What this PR does / why we need it:
Add type='button' to the clear input button in TimeRangeInput to prevent the default submit behavior.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@Clarity-89 Clarity-89 added add to changelog backport v9.2.x Mark PR for automatic backport to v9.2.x labels Oct 7, 2022
@Clarity-89 Clarity-89 added this to the 9.2.0 milestone Oct 7, 2022
@Clarity-89 Clarity-89 self-assigned this Oct 7, 2022
@Clarity-89 Clarity-89 requested review from a team, codeincarnate, oscarkilhed and JoaoSilvaGrafana and removed request for a team October 7, 2022 12:05
@grafanabot
Copy link
Contributor

Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 👏

@Clarity-89 Clarity-89 merged commit d332747 into main Oct 10, 2022
@Clarity-89 Clarity-89 deleted the timerangeinput/fix-btn-type branch October 10, 2022 14:05
@grafanabot
Copy link
Contributor

The backport to v9.2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-56545-to-v9.2.x origin/v9.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x d332747c38aadd6e1e1bdccd8a5ca87454a62fe9
# Push it to GitHub
git push --set-upstream origin backport-56545-to-v9.2.x
git switch main
# Remove the local backport branch
git branch -D backport-56545-to-v9.2.x

Then, create a pull request where the base branch is v9.2.x and the compare/head branch is backport-56545-to-v9.2.x.

@Clarity-89 Clarity-89 modified the milestones: 9.2.0, 9.3.0 Oct 10, 2022
@Clarity-89 Clarity-89 added no-backport Skip backport of PR and removed backport v9.2.x Mark PR for automatic backport to v9.2.x labels Oct 10, 2022
@leandro-deveikis leandro-deveikis modified the milestones: 9.3.0, 9.3.0-beta1 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants