Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanelEdit: Fixes bug with not remembering panel options pane collapse/expand state #59265

Merged
merged 1 commit into from
Nov 24, 2022
Merged

PanelEdit: Fixes bug with not remembering panel options pane collapse/expand state #59265

merged 1 commit into from
Nov 24, 2022

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Nov 24, 2022

Fixes a bug with Panel edit where the panel options pane expand / collapse state was not being stored in
local storage so not being restored on full page reload.

I have tried to identify when this bug was introduced without success. Looks like a very long time a go
but why have we not noticed it if that is the case? Confusing :)

@torkelo torkelo added this to the 9.3.0 milestone Nov 24, 2022
@grafanabot
Copy link
Contributor

Hello @torkelo!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@grafana grafana deleted a comment from grafanabot Nov 24, 2022
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/43198

ivanortegaalba
ivanortegaalba approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@ivanortegaalba ivanortegaalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After
2022-11-24 10 31 00 2022-11-24 10 32 35

@torkelo torkelo merged commit d766383 into main Nov 24, 2022
@torkelo torkelo deleted the fix-panel-editor-ui-state branch November 24, 2022 15:03
@grafanabot grafanabot mentioned this pull request Nov 24, 2022
Merged
grafanabot pushed a commit that referenced this pull request Nov 24, 2022
@torkelo @grafanabot
PanelEdit: Fixes bug with not remembering panel options pane collapse…
f7f5955 
…/expand state (#59265)

(cherry picked from commit d766383)
torkelo added a commit that referenced this pull request Dec 8, 2022
@grafanabot @torkelo
[v9.3.x] PanelEdit: Fixes bug with not remembering panel options pane…
8172672 
… collapse/expand state (#59309)

PanelEdit: Fixes bug with not remembering panel options pane collapse/expand state (#59265)

(cherry picked from commit d766383)

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
@grafanabot @torkelo @GuaYounesPW
[v9.3.x] PanelEdit: Fixes bug with not remembering panel options pane…
9ff3a64 
… collapse/expand state (grafana#59309)

PanelEdit: Fixes bug with not remembering panel options pane collapse/expand state (grafana#59265)

(cherry picked from commit d766383)

Co-authored-by: Torkel Ödegaard <torkel@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanortegaalba ivanortegaalba ivanortegaalba approved these changes

@kaydelaney kaydelaney Awaiting requested review from kaydelaney

Assignees
No one assigned
Labels
add to changelog area/dashboard area/frontend area/panel/edit backport v9.3.x enterprise-failed type/bug
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@torkelo @grafanabot @ivanortegaalba