API: Permit Cache-Control (browser caching) for datasource resources #62033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebrandt
force-pushed
the
resourceCacheControl
branch
from
7cfce8f
to
70401d4
Compare
kylebrandt
changed the title
kylebrandt
requested review from
sakjur,
tolzhabayev,
mildwonkey,
papagian and
marefr
and removed request for
a team
gtk-grafana
requested review from
gtk-grafana
and removed request for
gtk-grafana
Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
ryantxu
pushed a commit
that referenced
this pull request
Feb 3, 2023
…62033) * Start work on allowing certain resources to pass through Cache-Control headers. --------- Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
gtk-grafana
reviewed
Feb 7, 2023
|
|
||
| foundPrivate := false | ||
| foundPublic := false | ||
| for _, val := range ccHeaderValues { |
There was a problem hiding this comment.
ccHeaderValues is a string of comma separated values, so if the cache control includes a max-age this check will fail.
For example, I would expect to be able to set the following headers in the datasource resource.go:
Cache-Control: private, max-age=806400
X-Grafana-Cache: y
and have that pass this check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow Cache-Control trough and not overwrite it if:
X-Grafana-Cacheheader is setThe more immediate goal is to allow certain resources in Prometheus to be cached to improve query builder specifically. This is a piece of that.
X-Grafana-Cacheis a header that I believe I just made up (there is aX-Grafana-NoCachealready). The idea is to make it "opt-in", so this change doesn't unintentionally change other data sources in unanticipated ways.