Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger and Zipkin: Config & docs upgrade #64250

Merged
merged 20 commits into from
Mar 16, 2023

Conversation

joey-grafana
Copy link
Contributor

What is this feature?

Similar to #64017, this PR updates the Jaeger & Zipkin data source config pages and docs, while also adding a few updates to Tempo.

Why do we need this feature?

Make it clearer what each section in the config pages does and improving our docs.

Who is this feature for?

Jaeger/Zipkin/Tempo users.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Backend code coverage report for PR #64250
No changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Frontend code coverage report for PR #64250

Plugin Main PR Difference
explore 86.42% 86.45% .03%

@joey-grafana joey-grafana marked this pull request as ready for review March 6, 2023 17:49
@joey-grafana joey-grafana requested review from joshhunt and tskarhed and removed request for a team, Eve832, GrafanaWriter and joshhunt March 6, 2023 17:49
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the doc! I've made some minor changes to clarify wording.

joey-grafana and others added 15 commits March 10, 2023 10:52
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
@joey-grafana
Copy link
Contributor Author

Thank you for updating the doc! I've made some minor changes to clarify wording.

Thank you, Kim. I have committed all the changes you suggested :)

joey-grafana and others added 3 commits March 10, 2023 10:58
Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding doc. :)

@joey-grafana joey-grafana merged commit 596e5b4 into main Mar 16, 2023
@joey-grafana joey-grafana deleted the joey/jaeger-and-zipkin-config-and-docs-upgrade branch March 16, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants