-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Fix stats that display alert count when using unified alerting #64852
Conversation
Hello @gotjosh!
Please, if the current pull request addresses a bug fix, label it with the |
This pull request was removed from the 9.4.6 milestone because 9.4.6 is currently being released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
I guess this view is not per-org? Also, I was originally hesitant to capture the entire setting.Cfg
for one field, but this service does span many areas... so that's probably OK.
Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>
Is there a way in which I can import only the boolean? I'd think there isn't given the "settings" struct needs to be provided directly. |
This pull request was removed from the 9.4.7 milestone because 9.4.7 is currently being released. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-64852-to-v9.4.x origin/v9.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 02a8f62021750b0af6dd8760ca2516e5e285a998
# Push it to GitHub
git push --set-upstream origin backport-64852-to-v9.4.x
git switch main
# Remove the local backport branch
git branch -D backport-64852-to-v9.4.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-64852-to-v9.4.x origin/v9.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 02a8f62021750b0af6dd8760ca2516e5e285a998
# Push it to GitHub
git push --set-upstream origin backport-64852-to-v9.4.x
git switch main
# Remove the local backport branch
git branch -D backport-64852-to-v9.4.x Then, create a pull request where the |
These stats are incorrect when using unified alerting as they query the legacy alert rule table. Now, we conditionally query one of the other.
TODO