Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing: Docs and config improvements for Tempo/Jaeger/Zipkin #65255

Merged
merged 7 commits into from
Mar 30, 2023

Conversation

joey-grafana
Copy link
Contributor

@joey-grafana joey-grafana commented Mar 23, 2023

What is this feature?

Improves the docs for Tempo, Jaeger & Zipkin.

Why do we need this feature?

Makes how to use and configure these data sources clearer. Updates provisioning examples, terminology and descriptive text.

Who is this feature for?

Anyone who uses the Tempo, Jaeger or Zipkin data sources.

Which issue(s) does this PR fix?:

Fixes #64659

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.

@github-actions
Copy link
Contributor

Backend code coverage report for PR #65255
No changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

Frontend code coverage report for PR #65255

Plugin Main PR Difference
explore 86.48% 86.48% 0%

@joey-grafana joey-grafana marked this pull request as ready for review March 23, 2023 12:38
@joey-grafana joey-grafana requested review from tskarhed, yaelleC and knylander-grafana and removed request for a team, tskarhed and yaelleC March 23, 2023 12:38
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding documentation! Approving the changes, with some minor suggestions.

Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joey-grafana , after you've accepted @knylander-grafana suggestions, hit me up directly to merge this for you (if you are unable to merge yourself). Thanks for the great work!

@joey-grafana joey-grafana merged commit 10d896d into main Mar 30, 2023
@joey-grafana joey-grafana deleted the joey/update-tempo-jaeger-zipkin-docs-and-config branch March 30, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace to log custom query not working in provisioning file
5 participants