Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: When dashboard is not found show message instead of empty page #65508

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

polibb
Copy link
Contributor

@polibb polibb commented Mar 29, 2023

What is this feature?
Adds a view for Not Found dashboard.

Why do we need this feature?
Because Not Found dashboard is treated the same as an empty one right now.

Special notes for your reviewer:

I think we can also stop the initialisation of the dashboard here: initDashboard#L161 by sending a dispatch(dashboardInitFailed({ message: 'Not found', error: 'Not found' })) and render the Failed page. Thoughts?

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 27 existing alerts. Please check the repository Security tab to see all alerts.

@polibb polibb marked this pull request as ready for review March 29, 2023 09:09
@polibb polibb requested a review from a team as a code owner March 29, 2023 09:09
@polibb polibb requested review from ivanortegaalba and juanicabanas and removed request for a team March 29, 2023 09:09
@polibb polibb added this to the 9.5.0 milestone Mar 29, 2023
Copy link
Member

@dprokop dprokop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse the view from https://github.com/grafana/grafana/blob/dashboard/not-found-page/public/app/core/components/ErrorPage/ErrorPage.tsx#L8 for consistency?

Other than that this looks good.

@polibb
Copy link
Contributor Author

polibb commented Mar 30, 2023

Can we reuse the view from https://github.com/grafana/grafana/blob/dashboard/not-found-page/public/app/core/components/ErrorPage/ErrorPage.tsx#L8 for consistency?

Yes, and I like the fact that it looks less like a dashboard you can do stuff on 😁.

@polibb polibb merged commit 6f81829 into main Mar 30, 2023
@polibb polibb deleted the dashboard/not-found-page branch March 30, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants