Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Update legacy alerting warning #66269

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

armandgrillet
Copy link
Contributor

What is this feature?

Legacy alerting was supposed to be deleted in Grafana 10.0 but we will give it a few more months, we are clarifying our warning to state that the codebase will be deleted soon.

@armandgrillet armandgrillet added area/alerting Grafana Alerting add to changelog no-backport Skip backport of PR labels Apr 11, 2023
@armandgrillet armandgrillet added this to the 10.0.0 milestone Apr 11, 2023
@armandgrillet armandgrillet requested review from brendamuir and a team April 11, 2023 12:06
@armandgrillet armandgrillet self-assigned this Apr 11, 2023
@armandgrillet armandgrillet changed the title Update legacy alerting warning Alerting: Update legacy alerting warning Apr 11, 2023
@gillesdemey gillesdemey enabled auto-merge (squash) April 12, 2023 12:42
@brendamuir
Copy link
Contributor

Shall we update these statements to say "will be removed in Grafana 11"?

@gillesdemey
Copy link
Member

Yea, @armandgrillet care to update the original PR with the correct messaging about our deprecation intentions here?

@armandgrillet armandgrillet force-pushed the armandgrillet/legacy-alerting-removal-warning branch from 2c18785 to da161c4 Compare April 17, 2023 07:56
@armandgrillet armandgrillet enabled auto-merge (squash) April 17, 2023 07:56
@armandgrillet armandgrillet merged commit 075070d into main Apr 17, 2023
@armandgrillet armandgrillet deleted the armandgrillet/legacy-alerting-removal-warning branch April 17, 2023 08:02
adela-almasan pushed a commit that referenced this pull request Apr 17, 2023
* Update legacy alerting warning

* Apply suggestions from code review

Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>

* Update DeprecationNotice.tsx

* silly linter

* Clarify alerting deprecation

---------

Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>
Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
@dragoangel
Copy link

dragoangel commented Jun 16, 2023

I want to note that there is no confirmation as a code (file provisioning) available for new alerting. For now it's not possible to configure it with Helm chart as result. Thank you for deciding to not depracate it now (in version 10), does it planned to add provisioning in Grafana 10 before dropping old alerting?

@gillesdemey
Copy link
Member

Hi! You might want to take a look at the Grafana Alerting Provisioning API

@dragoangel
Copy link

dragoangel commented Jun 19, 2023

Hi! You might want to take a look at the Grafana Alerting Provisioning API

Hi, thank you, I know about this api, I mentioned it when stated particular support, but it's missing provisioning support in k8s right now via configmaps/secrets, right? When you have Grafana in stateless mode fully configured in k8s cluster you need this to be in place to properly setup alerting. Deprecating alerting have this support.

@gillesdemey
Copy link
Member

Have a look at the file provisioning, should work fine with k8s configmaps.

https://grafana.com/docs/grafana/latest/alerting/set-up/provision-alerting-resources/file-provisioning/

@dragoangel
Copy link

dragoangel commented Jun 19, 2023

Have a look at the file provisioning, should work fine with k8s configmaps.

https://grafana.com/docs/grafana/latest/alerting/set-up/provision-alerting-resources/file-provisioning/

I thought existing Contact Points & Notification are deprecating in Grafana 11, now I think I did not properly understand that part. I done https://grafana.com/docs/grafana/latest/alerting/migrating-alerts/opt-in/ and all looks working as usual, sorry for confusion.

Also, I know how to add alertmanger as datasource and turn "Receive Grafana Alerts" ON to be available in Grafana Admin Alerting, but:

  1. not clear how to provision this part: image
  2. and how to describe multiple URLs for HA setup of external alertmanger in datasource, it required to send alerts to multiple instances directly and display all alerts for sure. It is required when you use Nagstamon to check alerts at Alertmanager. Maybe dnssrv+ can be used there to solve such cases? In Contact Points I have all 3 replicas of Alertmanager in one section described for this purpose like this:
contact-prometheus-alertmanager.yaml: |-
  apiVersion: 1
  contactPoints:
    - orgId: 1
      name: prometheus-alertmanager
      receivers:
      {{- if gt ( .Values.alertmanager.alertmanagerSpec.replicas | int ) 1 }}
      {{ range $i, $e := until ( .Values.alertmanager.alertmanagerSpec.replicas | int ) }}
        - uid: prometheus-alertmanager-{{$i}}
          type: prometheus-alertmanager
          settings:
            url: http://alertmanager-monitoring-{{$i}}.alertmanager-operated:9093/
      {{end}}
      {{- else }}
        - uid: prometheus-alertmanager
          type: prometheus-alertmanager
          settings:
            url: http://alertmanager-monitoring.alertmanager-operated:9093/
      {{- end }}
  policies:
    - orgId: 1
      receiver: prometheus-alertmanager
      group_by: ['...']
      group_wait: 0s
      group_internval: 0s
      repeat_interval: 1m

P.s. "Legacy alerting will be deprecated in a future release (v10)." at https://grafana.com/docs/grafana/latest/alerting/migrating-alerts/ can be adjusted to v11

Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Jun 23, 2023
millerjason pushed a commit to millerjason/nixpkgs that referenced this pull request Jun 25, 2023
mccurdyc pushed a commit to mccurdyc/nixpkgs that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants