Tracing: Span filters reset filters and button #66781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joey-grafana
added
area/frontend
area/datasource/frontend
area/tracing
datasource/Tempo
no-backport
|
Backend code coverage report for PR #66781 |
|
Frontend code coverage report for PR #66781
|
ryantxu
pushed a commit
that referenced
this pull request
Apr 19, 2023
* Reset filters and button * Add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Resets the filters selected on new trace and also adds reset button.
Why do we need this feature?
So filters are accurate to current trace and users can quickly remove all filters if necessary.
Who is this feature for?
Users of span filters in the trace view.
Special notes for your reviewer:
Please check that: