Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: TooltipPlugin refactoring #70872

Closed
wants to merge 111 commits into from
Closed

Tooltip: TooltipPlugin refactoring #70872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
0a0a4d9
TooltipPlugin2
adela-almasan Jun 28, 2023
06a2a34
useLayoutEffect dependencies
adela-almasan Jun 28, 2023
1246e9c
more PoC variants
leeoniya Jun 29, 2023
5b24828
drop contain: strict;
leeoniya Jun 29, 2023
2356be1
random contents on datapoint change
leeoniya Jun 29, 2023
7e220b1
randomize content length
leeoniya Jun 29, 2023
246d1a0
z-index
leeoniya Jun 29, 2023
b141390
Merge remote-tracking branch 'origin/adela/tooltip_plugin' into adela…
adela-almasan Jun 29, 2023
2520535
Merge branch 'main' into adela/tooltip_plugin
adela-almasan Jun 29, 2023
713f5f7
more fake content in original plugin
leeoniya Jun 29, 2023
3052675
fix transform error
adela-almasan Jun 29, 2023
a876781
simplify?
leeoniya Jun 29, 2023
67425a0
poke the z-index of nearest .react-grid-item on hover/leave
leeoniya Jun 29, 2023
8e0ba90
swap comments
leeoniya Jun 30, 2023
b3df98f
viewport positioning
leeoniya Jun 30, 2023
7925d46
fixups
leeoniya Jun 30, 2023
b1a5c4c
avoid getBoundingClientRect(), pluggable content rendering
leeoniya Jun 30, 2023
a6c8440
use uPlot dev build
leeoniya Jun 30, 2023
f194e44
wip tooltip pinning (context menu)
leeoniya Jun 30, 2023
cdcf813
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jun 30, 2023
48c9da3
meh
leeoniya Jun 30, 2023
7c70848
pass through _isPinned
leeoniya Jul 1, 2023
8a61ef8
Merge branch 'main' into adela/tooltip_plugin
adela-almasan Jul 5, 2023
ea0f24b
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 5, 2023
e70d2f3
bump uPlot, drop syncRect hooks
leeoniya Jul 5, 2023
ecef9b1
set new cursor pos on unpin
leeoniya Jul 5, 2023
43b652e
fix errors in panel edit mode when there's no parent react-grid-item
leeoniya Jul 5, 2023
6ed9211
kinda fix tooltip overflow in panel edit
leeoniya Jul 5, 2023
32d334c
debounce content rendering via queueMicrotask
leeoniya Jul 5, 2023
87e0988
apples
leeoniya Jul 5, 2023
a998f7c
reuse <SeriesTable> for content
leeoniya Jul 6, 2023
75fa4e8
bring back content
leeoniya Jul 6, 2023
2d1f0d7
skip bold styling for single-series datasets
leeoniya Jul 6, 2023
aa34ff7
tweaks
leeoniya Jul 6, 2023
ca3bf48
xychart test
leeoniya Jul 6, 2023
7303d24
heatmap test
leeoniya Jul 6, 2023
da07239
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 6, 2023
a3cec47
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 6, 2023
b34a051
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 7, 2023
901b72b
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 10, 2023
f1c2a01
useState -> useReducer, disable tooltip -> legend interaction for now
leeoniya Jul 10, 2023
01c382c
simplify, move some hover state changes to setLegend hook
leeoniya Jul 11, 2023
bfecc7d
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 11, 2023
51284c5
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 11, 2023
2f05fe6
extract resizeobserver
leeoniya Jul 11, 2023
0d7d6e7
fix contentRect.height
leeoniya Jul 11, 2023
96f6626
simple unhover debounce
leeoniya Jul 12, 2023
1a83ebd
cleanup
leeoniya Jul 12, 2023
38af80b
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 12, 2023
efbb27d
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 12, 2023
148a72a
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 13, 2023
bcc2ffe
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 13, 2023
5b30a21
add dismiss callback
adela-almasan Jul 13, 2023
50fd858
sync styling
adela-almasan Jul 13, 2023
fd9096c
Add close button
adela-almasan Jul 13, 2023
e9fd266
required fields
adela-almasan Jul 13, 2023
a19980f
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 13, 2023
aa4f3d3
onClose -> dismiss
leeoniya Jul 13, 2023
0ee514e
close button right
adela-almasan Jul 13, 2023
7c54b1d
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 13, 2023
8ca359b
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 17, 2023
7856689
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 18, 2023
2a1d3e5
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 18, 2023
a545cba
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 18, 2023
7d0d0a6
bump uplot
leeoniya Jul 18, 2023
a11b1d2
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 19, 2023
1cb1946
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 19, 2023
f33dee2
fix css
adela-almasan Jul 19, 2023
56a48e5
set pointer-events: none; on dismiss()
leeoniya Jul 19, 2023
1eebb07
bump uPlot
leeoniya Jul 20, 2023
d62b654
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 20, 2023
5ec472b
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 20, 2023
cb2904d
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 20, 2023
924a6c9
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 21, 2023
74f891b
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 21, 2023
328d1e3
Merge branch 'main' into adela/tooltip_plugin
leeoniya Jul 21, 2023
2809748
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 24, 2023
9dceda3
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 24, 2023
5cfaf96
fix tooltip
adela-almasan Jul 24, 2023
0962145
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 25, 2023
a6e23ec
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 26, 2023
b59a60f
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Jul 27, 2023
1f28226
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Aug 1, 2023
fe12ac2
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Aug 1, 2023
8441022
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Aug 2, 2023
cacf652
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Aug 14, 2023
5ee5d31
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Aug 15, 2023
e36350c
Merge remote-tracking branch 'origin' into adela/tooltip_plugin
nmarrs Aug 17, 2023
d562ffe
add todo to remove hack scss implementation for zindex in favor of #7…
nmarrs Aug 17, 2023
74cba56
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Aug 24, 2023
c9d60f0
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Aug 28, 2023
3c7b6d7
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Aug 30, 2023
878ad53
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Aug 31, 2023
3630963
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Sep 26, 2023
9c32fec
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Sep 27, 2023
e921ff8
close button update
adela-almasan Sep 27, 2023
2ddbce1
Merge branch 'main' into tooltip_plugin_refactoring
adela-almasan Sep 27, 2023
86a072d
remove react-grid-item styling
adela-almasan Sep 27, 2023
b176eba
rename to TooltipPlugin2
adela-almasan Sep 27, 2023
a9db1b0
non-grid panel z-index and overflow changes
leeoniya Sep 28, 2023
2cd868a
fix some stuffs
leeoniya Sep 28, 2023
612134e
different approach
leeoniya Sep 28, 2023
abadf6d
use css object
leeoniya Sep 28, 2023
c99cc10
remove
leeoniya Sep 29, 2023
3871576
Merge branch 'main' into adela/tooltip_plugin
leeoniya Sep 29, 2023
dfeedc9
revert splitpanewrapper
leeoniya Sep 29, 2023
964c29f
revert panelchrome
leeoniya Sep 29, 2023
5bc69c3
more revert
leeoniya Sep 29, 2023
3e7e05e
Revert XY Changes
adela-almasan Oct 2, 2023
dc8cd1d
Revert Timeseries changes
adela-almasan Oct 2, 2023
b9ba513
Revert Heatmap changes
adela-almasan Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grafana-ui/src/components/uPlot/config/UPlotConfigBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const cursorDefaults: Cursor = {
width: (u, seriesIdx, size) => size / 4,
},
focus: {
prox: 30,
prox: 10,
},
};

Expand Down
2 changes: 1 addition & 1 deletion packages/grafana-ui/src/components/uPlot/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const DEFAULT_PLOT_CONFIG: Partial<Options> = {
},
cursor: {
focus: {
prox: 30,
prox: 10,
},
},
legend: {
Expand Down
Loading