Tooltip: TooltipPlugin refactoring #70872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafanabot
added
area/frontend
area/panel/timeseries
…/tooltip_plugin # Conflicts: # packages/grafana-ui/src/components/uPlot/plugins/TooltipPlugin2.tsx
torkelo
reviewed
Jul 4, 2023
3 tasks
3 tasks
Merged
# Conflicts: # package.json # packages/grafana-data/package.json # packages/grafana-ui/package.json # yarn.lock
# Conflicts: # public/app/plugins/panel/timeseries/TimeSeriesPanel.tsx
# Conflicts: # packages/grafana-ui/src/components/PanelChrome/PanelChrome.tsx # public/sass/pages/_dashboard.scss
leeoniya
force-pushed
the
adela/tooltip_plugin
branch
from
5aa25dd
to
a9db1b0
Compare
This was referenced Oct 2, 2023
|
Closing this one as we've merged/extracted functionality out of it already. |
adela-almasan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the tooltip so it is now portaled into uplot's dom vs the global portal, solving a lot of tricky positioning issues, especially with dashboard scrolling and resize. It's also much faster since the browser tracks/syncs the relative offset vs the current logic.
Please check that: