New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Revert dskit service additions #72608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
20ce869
to
e91c4b4
Compare
/deploy-to-hg |
|
Error: Contact #proj-ephemeral-hg-instances if it is not a compile error handling pull request comment event: running grafana-build package: executing command: stdout= stderr=go: downloading github.com/urfave/cli/v2 v2.24.4 Stderr: github.com/grafana/grafana/pkg/extensions/provisioning/servicepkg/extensions/provisioning/service/service.go:35:96: undefined: modules.Provisioning Please visit https://dagger.io/help#go for troubleshooting guidance. |
/deploy-to-hg --enterprise-ref toddtreece/remove-dskit-services |
|
|
What is this feature?
The current migration approach mixed use cases for dskit modules and services. One use case was for deployment mode targets, and the other allowed existing background services to be migrated to dskit services if there was a need to control startup order.
Mixing these two approaches will be too brittle long term due to the way wire dependencies are currently setup. A follow-up PR will focus the use case on only using dskit modules and services for the deployment mode use case.
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
@grafana/grafana-app-platform-squad
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: