Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Dashboard: Reduce scope of contain: strict to TextPanel #75466

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

dprokop
Copy link
Member

@dprokop dprokop commented Sep 26, 2023

This reverts commit ade0de5 that caused issues with panels content overlapping the panel container.

I.e. dashboards list:

image

@dprokop dprokop requested a review from a team as a code owner September 26, 2023 15:38
@dprokop dprokop requested review from joshhunt, L-M-K-B, leeoniya and a team and removed request for a team September 26, 2023 15:38
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Sep 26, 2023
@dprokop dprokop added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes and removed area/frontend labels Sep 26, 2023
@dprokop dprokop enabled auto-merge (squash) September 26, 2023 15:40
@dprokop
Copy link
Member Author

dprokop commented Sep 26, 2023

My guess is that when implementing new PanelChrome we removed some styling that was there, and that was covered by the contain: strict rule.

Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya... the default landing page is now full full full height 😢

@dprokop dprokop merged commit 918f11d into main Sep 26, 2023
34 checks passed
@dprokop dprokop deleted the revert-ade0de5 branch September 26, 2023 15:51
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants