New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Fix panels overlapping Save Drawer #76675
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshhunt
added
type/bug
no-changelog
Skip including change in changelog/release notes
labels
Oct 17, 2023
joshhunt
requested review from
ivanortegaalba and
polibb
and removed request for
a team
October 17, 2023 08:52
polibb
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smart 🙌
darrenjaneczek
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Dashboard: Fix panels overlapping * comments
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
* Dashboard: Fix panels overlapping * comments (cherry picked from commit 67e2430)
leeoniya
pushed a commit
that referenced
this pull request
Nov 6, 2023
summerwollin
pushed a commit
that referenced
this pull request
Nov 15, 2023
* Dashboard: Fix panels overlapping * comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/frontend
backport v10.2.x
no-changelog
Skip including change in changelog/release notes
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced in #75328 where Dashboards with more than 1020 panels would have their panels z index raised above tooltips and drawers.
This PR fixes the issue by making sure the panels are in their own stacking context so they cannot overlap anymore.
Before:
After: