Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Fix panels overlapping Save Drawer #76675

Merged
merged 2 commits into from Oct 17, 2023

Conversation

joshhunt
Copy link
Contributor

Fixes an issue introduced in #75328 where Dashboards with more than 1020 panels would have their panels z index raised above tooltips and drawers.

This PR fixes the issue by making sure the panels are in their own stacking context so they cannot overlap anymore.

Before:

6Y8MkBq5rL

After:

vT6jnm7O8X

@joshhunt joshhunt added type/bug no-changelog Skip including change in changelog/release notes labels Oct 17, 2023
@joshhunt joshhunt requested a review from a team as a code owner October 17, 2023 08:52
@joshhunt joshhunt requested review from ivanortegaalba and polibb and removed request for a team October 17, 2023 08:52
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Oct 17, 2023
Copy link
Contributor

@polibb polibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart 🙌

@joshhunt joshhunt added the no-backport Skip backport of PR label Oct 17, 2023
@joshhunt joshhunt enabled auto-merge (squash) October 17, 2023 10:11
@joshhunt joshhunt merged commit 67e2430 into main Oct 17, 2023
20 checks passed
@joshhunt joshhunt deleted the joshhunt/fix-dash-grid-item-z-index branch October 17, 2023 10:11
@zerok zerok modified the milestones: 10.2.x, 10.3.x Oct 19, 2023
darrenjaneczek pushed a commit that referenced this pull request Oct 23, 2023
* Dashboard: Fix panels overlapping

* comments
@leeoniya leeoniya added backport v10.2.x and removed no-backport Skip backport of PR labels Nov 6, 2023
grafana-delivery-bot bot pushed a commit that referenced this pull request Nov 6, 2023
* Dashboard: Fix panels overlapping

* comments

(cherry picked from commit 67e2430)
leeoniya pushed a commit that referenced this pull request Nov 6, 2023
Dashboard: Fix panels overlapping Save Drawer (#76675)

* Dashboard: Fix panels overlapping

* comments

(cherry picked from commit 67e2430)

Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com>
summerwollin pushed a commit that referenced this pull request Nov 15, 2023
* Dashboard: Fix panels overlapping

* comments
@aangelisc aangelisc modified the milestones: 10.3.x, 10.2.3 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend backport v10.2.x no-changelog Skip including change in changelog/release notes type/bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants