VizTooltips: Use global portal #81986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
requested review from
drew08t and
adela-almasan
and removed request for
a team
grafana-pr-automation
bot
added
area/frontend
area/panel/timeseries
|
Getting an error with this enabled in certain conditions in which it appears to be causing some overflow causing the global scrollbar to flicker. See screen recording: scrollbar.error-2024-02-22_22.34.05.mp4 |
codeincarnate
requested changes
Feb 23, 2024
what error are you getting? the occasional flicker close to bottom and right viewport edges is known, but i want to leave the fix for later as it's not a 1-liner - i think we need to render the tooltip initially with |
codeincarnate
approved these changes
Feb 23, 2024
leeoniya
requested review from
joshhunt,
Clarity-89 and
jackw
and removed request for
a team
yuri-tceretian
pushed a commit
that referenced
this pull request
Feb 26, 2024
Co-authored-by: Adela Almasan <adela.almasan@grafana.com>
chalapat
pushed a commit
to nokia/grafana
that referenced
this pull request
Feb 27, 2024
Co-authored-by: Adela Almasan <adela.almasan@grafana.com>
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this refactors
newVizTooltipsto use a global portal for tooltips and annotation editor/infotip. this fixes a number of tricky z-index issues with portalling tooltips into the panels, especially with shared tooltips, but also with the panel resize-handle in each panel appearing on top of the tooltips.this also removes the condition to use old tooltips for dashboards with shared tooltip mode. the new behavior is to always use Multi/All mode for tooltips in synced panels.
there will be a follow-up PR to revert previous z-index changes we did in dashboards and scenes that were needed for panel-local portalling:
we could potentially revert #75499, but i think that can stay in place.