New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: upgrade to msw v2 #82270
Merged
Merged
Chore: upgrade to msw v2 #82270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
type/chore
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
labels
Feb 9, 2024
ashharrison90
commented
Feb 9, 2024
ashharrison90
requested review from
AgnesToulet,
lucychen-grafana,
L-M-K-B and
JoaoSilvaGrafana
and removed request for
a team
February 12, 2024 17:36
ashharrison90
requested review from
gillesdemey,
konrad147 and
soniaAguilarPeiron
February 12, 2024 17:36
konrad147
reviewed
Feb 13, 2024
public/app/features/alerting/unified/components/rules/RuleDetails.test.tsx
Show resolved
Hide resolved
jackw
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plugin loader part of this PR looks good to me! Awesome work @ashharrison90 ! 馃殌
konrad147
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alerting part LGTM!
Ukochka
pushed a commit
that referenced
this pull request
Feb 14, 2024
* Update dependency msw to v2 * close * minor fixes * fetch import changes * fix some alerting tests * fix another alerting test * fix systemjs tests * don't return undefined in json mocks * don't return undefined in json response * add type --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/frontend
datasource/Prometheus
no-backport
Skip backport of PR
no-changelog
Skip including change in changelog/release notes
type/chore
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
based off the renovate PR here, but split it out into it's own PR as there are a lot of changes
Please check that: