Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade to msw v2 #82270

Merged
merged 11 commits into from Feb 14, 2024
Merged

Chore: upgrade to msw v2 #82270

merged 11 commits into from Feb 14, 2024

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented Feb 9, 2024

What is this feature?

Why do we need this feature?

  • gotta keep updating!
  • api is a little nicer 馃憤

Who is this feature for?

  • grafana devs

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

based off the renovate PR here, but split it out into it's own PR as there are a lot of changes

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added type/chore no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Feb 9, 2024
@ashharrison90 ashharrison90 added this to the 10.4.x milestone Feb 9, 2024
@ashharrison90 ashharrison90 self-assigned this Feb 9, 2024
jest.config.js Outdated Show resolved Hide resolved
@ashharrison90 ashharrison90 marked this pull request as ready for review February 12, 2024 17:36
@ashharrison90 ashharrison90 requested review from a team as code owners February 12, 2024 17:36
@ashharrison90 ashharrison90 requested review from AgnesToulet, lucychen-grafana, L-M-K-B and JoaoSilvaGrafana and removed request for a team February 12, 2024 17:36
Copy link
Contributor

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin loader part of this PR looks good to me! Awesome work @ashharrison90 ! 馃殌

Copy link
Contributor

@konrad147 konrad147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting part LGTM!

@ashharrison90 ashharrison90 merged commit cf65d91 into main Feb 14, 2024
14 checks passed
@ashharrison90 ashharrison90 deleted the ash/msw-v2 branch February 14, 2024 13:16
Ukochka pushed a commit that referenced this pull request Feb 14, 2024
* Update dependency msw to v2

* close

* minor fixes

* fetch import changes

* fix some alerting tests

* fix another alerting test

* fix systemjs tests

* don't return undefined in json mocks

* don't return undefined in json response

* add type

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend datasource/Prometheus no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants